betodealmeida opened a new pull request #17336: URL: https://github.com/apache/superset/pull/17336
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> When sending the screenshot of a table in a report we should honor `d3NumberFormat` on columns. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> The chart: <img width="1268" alt="Screen Shot 2021-11-03 at 9 59 11 AM" src="https://user-images.githubusercontent.com/1534870/140118026-648ea71f-07e6-43d6-9c19-91dc436a3776.png";> The report, before:  The report, after:  ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> 1. Create a table chart, go to customize, and set a column's "d3 format" to `,d`. 2. Create a report. 3. Check that format matches (comma separated groups of thousands, in this case). ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/1534870/140118026-648ea71f-07e6-43d6-9c19-91dc436a3776.png"](https://user-images.githubusercontent.com/1534870/140118026-648ea71f-07e6-43d6-9c19-91dc436a3776.png"){kind=link}
