etr2460 commented on a change in pull request #17202:
URL: https://github.com/apache/superset/pull/17202#discussion_r743762734
##########
File path:
superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsx
##########
@@ -370,7 +380,11 @@ export default class AdhocMetricEditPopover extends
React.PureComponent {
/>
</FormItem>
</Tabs.TabPane>
- <Tabs.TabPane key={EXPRESSION_TYPES.SIMPLE} tab={t('Simple')}>
+ <Tabs.TabPane
+ key={EXPRESSION_TYPES.SIMPLE}
+ tab={t('Simple')}
Review comment:
Meaning a tooltip that is displayed when you hover over the disabled tab
selector. something like this? maybe with different content depending on why
it's disabled?
```tsx
tab={<Tooltip content={t('You may not define ad hoc metrics because it is
disabled by the dataset owner.')}>{t('Simple')}</Tooltip>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
