villebro commented on a change in pull request #17353:
URL: https://github.com/apache/superset/pull/17353#discussion_r744440877
##########
File path: superset/db_engine_specs/drill.py
##########
@@ -68,3 +68,12 @@ def convert_dttm(cls, target_type: str, dttm: datetime) ->
Optional[str]:
def adjust_database_uri(cls, uri: URL, selected_schema: Optional[str]) ->
None:
if selected_schema:
uri.database = parse.quote(selected_schema, safe="")
+
+ @classmethod
+ def modify_url_for_impersonation(cls, url: URL, impersonate_user: bool,
username: Optional[str]) -> None:
+ if impersonate_user and username is not None:
+ if url.drivername == "drill+odbc":
+ url.query["DelegationUID"] = username
Review comment:
@Z0ltrix I personally think you can include it if it is expected to work
even if you haven't been able to test it yourself; if it doesn't someone else
can continue the work by posting a follow-up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
