ktmud commented on a change in pull request #17202:
URL: https://github.com/apache/superset/pull/17202#discussion_r745114063
##########
File path:
superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover/index.jsx
##########
@@ -370,7 +381,23 @@ export default class AdhocMetricEditPopover extends
React.PureComponent {
/>
</FormItem>
</Tabs.TabPane>
- <Tabs.TabPane key={EXPRESSION_TYPES.SIMPLE} tab={t('Simple')}>
+ <Tabs.TabPane
+ key={EXPRESSION_TYPES.SIMPLE}
+ tab={
+ extra.disallow_adhoc_metrics ? (
+ <Tooltip
+ title={t(
+ 'Simple ad-hoc metrics are not enabled for this dataset',
Review comment:
I think these are two different scenarios. You can still use a different
message for native Druid. IMO clarity is more important than consistency. If we
have only one config value `disallow_ahoc_metrics`, then the message should
corresponds to what this config value does----which isn't disabling SIMPLE and
CUSTOM SQL separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
