michael-s-molina commented on a change in pull request #17337: URL: https://github.com/apache/superset/pull/17337#discussion_r745769882
########## File path: superset/key_value/commands/cleanup.py ########## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import logging +from datetime import datetime, timedelta + +from superset.commands.base import BaseCommand +from superset.models.key_value import KeyValue +from superset.key_value.utils import is_expired +from superset.utils.celery import session_scope + +logger = logging.getLogger(__name__) + + +class CleanupCommand(BaseCommand): + """ + Expiration cleanup command. + """ + + def __init__(self, worker_context: bool = True): + self._worker_context = worker_context + + def run(self) -> None: + logger.info("Key value store cleanup starting") + with session_scope(nullpool=True) as session: + for keyValue in session.query(KeyValue).all(): + if is_expired(keyValue): Review comment: Yes. In fact, I'm currently doing this exact change. I'm just trying to learn how to do that with SQL Alchemy since this is my first Python PR :sweat_smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
