eschutho commented on a change in pull request #17386:
URL: https://github.com/apache/superset/pull/17386#discussion_r746162720
##########
File path: superset-frontend/src/SqlLab/components/TableElement/index.tsx
##########
@@ -221,12 +230,15 @@ const TableElement = ({ table, actions, ...props }:
TableElementProps) => {
>
<Tooltip
id="copy-to-clipboard-tooltip"
- placement="topLeft"
style={{ cursor: 'pointer' }}
title={table.name}
- trigger={['hover']}
+ trigger={tableNameOverflow ? ['hover'] : []}
Review comment:
I feel like if you're reading the property of a ref here to determine
the trigger, you could prob just define the trigger as a const in this
renderHeader function. I don't think you necessarily need the useEffect or
state for this. That could simplify this code a bit. wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
