lyndsiWilliams commented on a change in pull request #17385:
URL: https://github.com/apache/superset/pull/17385#discussion_r746803237
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -426,14 +426,7 @@ export default class FilterableTable extends PureComponent<
}) {
const columnKey = this.props.orderedColumnKeys[columnIndex];
const cellData = this.list[rowIndex][columnKey];
- const content =
- cellData === null ? (
- <i className="text-muted">
- {this.getCellContent({ cellData, columnKey })}
- </i>
- ) : (
- this.getCellContent({ cellData, columnKey })
- );
Review comment:
Oops, good catch! Added it back in [`this
commit`](https://github.com/apache/superset/pull/17385/commits/2f152047ea98eac08fb482a0f5834fd98ced20e7).
My initial attempt was to add this logic to `getCellContent`, but that
function needs to get just the text content of each cell, it doesn't like
components. It uses the text to get the width of the columns. I tried working
around the function to get it to accept elements too but I couldn't find a way,
since it needs to output just a string of what's inside the cell for sizing
purposes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
