suddjian commented on pull request #17344: URL: https://github.com/apache/superset/pull/17344#issuecomment-965694168
I think if it's possible to split this change into smaller PRs, that will make it much more reviewable. Also, as the purpose of this PR is to make the code testable, I think it would be appropriate and necessary to add tests as part of the refactor. And if there are any existing tests that cover parts of this, would you mind linking to them? As a reviewer I find tests very helpful for understanding the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
