ofekisr opened a new pull request #17399: URL: https://github.com/apache/superset/pull/17399
### **Background** When working on #16991 we wanted to test the new functionalities in concrete and accurate unittest. but whole the chartData flows and its components are too couple to superset so it is impossible to create unittests. the flows are not testable and so many components do not meet the very important principle SRP and the code became so dirty so I've started to refactor it (#17344 ) but many changes were added and it was hard to review so I decided to split those changes to small PRs so will be easier to follow this is the First PR ### PR description Moving ChartDataResultType and ChartDataResultFormat from utils to common. think about it those are not utils and used by many places so it more sense to be in common ### test plans There are no logic change so new tests are not required -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
