geido commented on a change in pull request #17398:
URL: https://github.com/apache/superset/pull/17398#discussion_r747692152
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/nativeFilters.test.ts
##########
@@ -288,6 +286,51 @@ describe('Nativefilters Sanity test', () => {
'By default, each filter loads at most 1000 choices at the initial page
load. Check this box if you have more than 1000 filter values and want to
enable dynamically searching that loads filter values as users type (may add
stress to your database).',
);
});
+ it("User can check 'Filter has default value'", () => {
+ cy.get(nativeFilters.filterFromDashboardView.expand).click({ force: true
});
+ cy.get(nativeFilters.createFilterButton)
+ .should('be.visible')
+ .click({ force: true });
+ cy.get(nativeFilters.modal.container).should('be.visible');
+
+ cy.get(nativeFilters.modal.container)
+ .find(nativeFilters.filtersPanel.datasetName)
+ .click()
+ .type('wb_health_population{enter}');
+ cy.get(nativeFilters.modal.container)
+ .find(nativeFilters.filtersPanel.filterName)
+ .click()
+ .type('country_name');
+ cy.get('.loading inline-centered css-101mkpk').should('not.exist');
Review comment:
I think this might need to be like the following instead? Also, I would
avoid pointing to generated classes like this one if possible `css-101mkpk`
```suggestion
cy.get('.loading .inline-centered .css-101mkpk').should('not.exist');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
