geido opened a new pull request #17422: URL: https://github.com/apache/superset/pull/17422
### SUMMARY This PR: - Adds the ability to notify the user about custom label colors used in a Dashboard - Adds the ability to inform the user when a chart in Explore is having a dashboard context, thus the color scheme will be inherited from the dashboard. - Adds some test cases for the ColorSchemeControl which had none before - Fixes #17318 ### AFTER DASHBOARD https://user-images.githubusercontent.com/60598000/141459740-af81102e-c468-4fd7-855d-535c5c280804.mp4 ### AFTER EXPLORE https://user-images.githubusercontent.com/60598000/141459760-df5ed5b2-5888-4554-bb79-b116f7b1e5e3.mp4 ### TESTING INSTRUCTIONS 1. Open a Dashboard 2. Set a color scheme 3. Add custom label colors 4. Make sure the color scheme alerts you of custom label colors in use 4. Visit a chart 5. Make sure the color scheme cannot be changed in Explore ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #17318 - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
