villebro commented on a change in pull request #17379:
URL: https://github.com/apache/superset/pull/17379#discussion_r748277770
##########
File path:
superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx
##########
@@ -41,29 +52,49 @@ const StyledSelect = styled(Select)`
interface ColumnSelectPopoverProps {
columns: ColumnMeta[];
- editedColumn?: ColumnMeta;
- onChange: (column: ColumnMeta) => void;
+ editedColumn?: ColumnMeta | AdhocColumn;
+ onChange: (column: ColumnMeta | AdhocColumn) => void;
onClose: () => void;
+ setLabel: (title: string) => void;
+ getCurrentTab: (tab: string) => void;
+ label: string;
+ isAdhocColumnsEnabled: boolean;
}
+const height = 240;
Review comment:
This would be nice to have as a constant, as it's the same for adhoc
filters and metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
