eschutho opened a new pull request #17431: URL: https://github.com/apache/superset/pull/17431
### SUMMARY Use the full resultType when downloading a csv so that it takes the same cache key as the chart itself. See https://github.com/apache/superset/pull/17194 This fixes a bug where if you refreshed cache and then downloaded a csv from a dashboard, the csv results would be different than the chart. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF After: https://user-images.githubusercontent.com/5186919/141601024-8f2025b8-5833-4c8d-b5b7-692ad2ec9404.mov ### TESTING INSTRUCTIONS We should also test to see that the full csv report download has a row limit. ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
