stevetracvc commented on a change in pull request #16591:
URL: https://github.com/apache/superset/pull/16591#discussion_r749403840
##########
File path: superset-frontend/src/filters/components/Range/types.ts
##########
@@ -28,6 +28,8 @@ import { PluginFilterHooks, PluginFilterStylesProps } from
'../types';
interface PluginFilterSelectCustomizeProps {
max?: number;
min?: number;
+ stepSize: number;
+ logScale: boolean;
Review comment:
It looks like it's missing an export, as all the others have one. I'll
add it in.
```
grep 'PluginFilter.*CustomizeProps' -r
filters/components/GroupBy/types.ts:interface
PluginFilterGroupByCustomizeProps {
filters/components/GroupBy/types.ts: PluginFilterGroupByCustomizeProps;
filters/components/GroupBy/types.ts:export const DEFAULT_FORM_DATA:
PluginFilterGroupByCustomizeProps = {
filters/components/Range/types.ts:interface PluginFilterRangeCustomizeProps {
filters/components/Range/types.ts: PluginFilterSelectCustomizeProps;
filters/components/Select/types.ts:interface
PluginFilterSelectCustomizeProps {
filters/components/Select/types.ts: PluginFilterSelectCustomizeProps;
filters/components/Select/types.ts:export const DEFAULT_FORM_DATA:
PluginFilterSelectCustomizeProps = {
filters/components/Time/types.ts:interface PluginFilterTimeCustomizeProps {
filters/components/Time/types.ts: PluginFilterTimeCustomizeProps;
filters/components/Time/types.ts:export const DEFAULT_FORM_DATA:
PluginFilterTimeCustomizeProps = {
filters/components/TimeColumn/types.ts:interface
PluginFilterTimeColumnCustomizeProps {
filters/components/TimeColumn/types.ts:
PluginFilterTimeColumnCustomizeProps;
filters/components/TimeColumn/types.ts:export const DEFAULT_FORM_DATA:
PluginFilterTimeColumnCustomizeProps = {
filters/components/TimeGrain/types.ts:interface
PluginFilterTimeGrainCustomizeProps {
filters/components/TimeGrain/types.ts: PluginFilterTimeGrainCustomizeProps;
filters/components/TimeGrain/types.ts:export const DEFAULT_FORM_DATA:
PluginFilterTimeGrainCustomizeProps = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
