stevetracvc commented on pull request #16591: URL: https://github.com/apache/superset/pull/16591#issuecomment-969279732
> Some observations: > > * the step select control could look better if it were narrower on the config modal Agreed. How? I've just been reverse engineering these config panels (hah! and just now found some useful comments). I figured out how to get two on a line vs one, but adding a null to its ControlSetRow array didn't work to make it half-width. > * it was sometimes hard to keep track of when values were scaled and when not. I wonder if this could somehow be made clearer. Code-wise I tried to keep track with comments so I didn't get lost. What utility is there in showing that to the end user? Just to understand why the numbers change in a non-linear manner? If so, then maybe a popup when hovering over the range control? > * when the range slider is initialized, the values seem to get populated off the scale (see screenshot using the `num` column on the `birth_names` dataset) Yes, I've noticed that too, and I think I know why. I'll see if I can fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
