villebro commented on a change in pull request #17427:
URL: https://github.com/apache/superset/pull/17427#discussion_r750004881
##########
File path: superset-frontend/cypress-base/cypress/utils/parsePostForm.ts
##########
@@ -22,7 +22,7 @@
export default function parsePostForm(requestBody: ArrayBuffer) {
type ParsedFields = Record<string, string[] | string>;
if (requestBody.constructor.name !== 'ArrayBuffer') {
- return (requestBody as unknown) as ParsedFields;
+ return requestBody as unknown as ParsedFields;
Review comment:
I agree with Evan, let's do a cleanup pass after this to get rid of
these unknowns, they greatly aggravate my OCD 😄
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -195,9 +232,27 @@ module.exports = {
'error',
{ devDependencies: true },
],
- 'jest/consistent-test-it': 'error',
'no-only-tests/no-only-tests': 'error',
+ 'max-classes-per-file': 0,
'@typescript-eslint/no-non-null-assertion': 0,
+ 'jest/consistent-test-it': 'error',
+ 'jest/expect-expect': 0,
+ 'jest/no-test-prefixes': 0,
+ 'jest/valid-expect-in-promise': 0,
+ 'jest/valid-expect': 0,
+ 'jest/valid-title': 0,
+ 'jest-dom/prefer-to-have-attribute': 0,
+ 'jest-dom/prefer-to-have-text-content': 0,
+ 'jest-dom/prefer-to-have-style': 0,
Review comment:
Are these ignores really needed? If this is only temporary we should
probably add a todo or preferably to fix any violating tests. Especially
`jest/valid-expect-in-promise` feels like a pretty bad violation, and these
should probably be fixed to avoid flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
