villebro commented on a change in pull request #14305:
URL: https://github.com/apache/superset/pull/14305#discussion_r750424856
##########
File path: superset/views/core.py
##########
@@ -959,7 +959,7 @@ def save_or_overwrite_slice(
slc = Slice(owners=[g.user] if g.user else [])
form_data["adhoc_filters"] = self.remove_extra_filters(
- form_data.get("adhoc_filters", [])
+ (form_data.get("adhoc_filters", []) or [])
Review comment:
nit (I thought I added this comment, but it seems to have disappeared
into the ether); I think this should work just as well to handle where
`adhoc_filters` is set to `None`:
```suggestion
form_data.get("adhoc_filters") or []
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
