ofekisr opened a new pull request #17496:
URL: https://github.com/apache/superset/pull/17496


   ## **Background** 
   When we have worked on #16991 we wanted to test the new functionalities in 
concrete and accurate unittest.
   All chartData flows and its components are too couple to superset so it is 
impossible to create unittests. 
   The flows are not testable and so many components do not meet the very 
important principle SRP and the code became so dirty 
   
   So I've started to refactor it (#17344 ) but many changes were added and it 
was hard to review so I decided to split those changes into small PRs so will 
be easier to follow 
   
   This is the Eleventh PR in a sequence of PRs to meet these
   
   ## PR description
   QueryContext class contains static methods used as Dataframe utils. To meet 
SRP, those methods moved to a utils package.
   
   to keep the utils meeting SRP, it implies arranging the utils to be as 
package and separating each of the related methods into ad hoc modules. 
   
   ### Test plans 
   There is no logic added so new tests are not required
   
   ## Previous PRs
   1. #17399
   2. #17400 
   3. #17405 
   4. #17407 
   5. #17425 
   6. #17461 
   7. #17465 
   8. #17466 
   9. #17479 
   10. #17495 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to