geido commented on a change in pull request #17307:
URL: https://github.com/apache/superset/pull/17307#discussion_r755956860
##########
File path: superset/charts/schemas.py
##########
@@ -884,6 +884,9 @@ class AnnotationLayerSchema(Schema):
allow_none=True,
)
show = fields.Boolean(description="Should the layer be shown",
required=True)
+ showLabel = fields.Boolean(
+ description="Should the label always be shown", required=True,
Review comment:
I am wondering whether we should make this optional to avoid a breaking
change
##########
File path:
superset-frontend/src/explore/components/controls/AnnotationLayerControl/AnnotationLayer.jsx
##########
@@ -726,6 +738,14 @@ export default class AnnotationLayer extends
React.PureComponent {
value={!show}
onChange={v => this.setState({ show: !v })}
/>
+ <CheckboxControl
+ name="annotation-label-show"
+ label={t('Show Label')}
Review comment:
This is a nit, I think our convention is` Show label `rather than `Show
Label`
```suggestion
label={t('Show label')}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
