jayakrishnankk commented on pull request #17505: URL: https://github.com/apache/superset/pull/17505#issuecomment-977921206
I'm thinking in this direction. - By default the buttons will be at the top. - If configured (need to add a configuration option), it can be shown at the bottom. - If shown at the bottom, the "Cancel" and "Apply" buttons will be shown at the end of the available filters until the filters fill the page. - If shown at the bottom, and filters fill the page, make the buttons sticky at the bottom so that it is always visible, and scrollbar available to see all filters. Side note: if a dashboard falls into the last criteria, it is better for the dashboard builder to use the default position for the buttons which is at the top. Advantages: - No breaking change, or UX change in default behavior - Configurable option for those who wish to have these buttons at the bottom, because that is a better mental model for most filters. You change the filters and then apply at the end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
