alejandroparra opened a new pull request #17546:
URL: https://github.com/apache/superset/pull/17546


   <!---
   fix(docs): make sample code work
   -->
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Hi there!
   I was trying to set up the Custom OAuth2 Configuration but found out that 
one very important and necessary import is missing from the documentation in 
order to make the sample code work without any problem.
   
   the import missing is with the library OAuth, after several hours of 
searching and reading found that importing only that library doesn't work, what 
it works is to import the full OAuth library from 
flask_appbuilder.security.manager.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ x] Has associated issue: #17544
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to