villebro commented on a change in pull request #16619:
URL: https://github.com/apache/superset/pull/16619#discussion_r757317529
##########
File path: superset/views/core.py
##########
@@ -1912,6 +1914,7 @@ def dashboard(
bootstrap_data=json.dumps(
bootstrap_data, default=utils.pessimistic_json_iso_dttm_ser
),
+ standalone_mode=standalone_mode,
Review comment:
nit: since `standalone_mode` isn't being reused, I'd prefer to place it
inline here, like
```python
standalone_mode=ReservedUrlParameters.is_standalone_mode(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
