etr2460 commented on a change in pull request #17474:
URL: https://github.com/apache/superset/pull/17474#discussion_r758019803
##########
File path: superset-frontend/src/components/Form/Form.tsx
##########
@@ -29,7 +29,7 @@ const StyledForm = styled(AntDForm)`
}
`;
-export default function Form(props: FormProps) {
+export default function Form(props: any) {
Review comment:
yeah, let's remove this prop. since the css class isn't used anywhere,
then i think it's safe.
##########
File path: superset-frontend/src/CRUD/Fieldset.tsx
##########
@@ -17,31 +17,33 @@
* under the License.
*/
import React from 'react';
-import PropTypes from 'prop-types';
import { Form } from 'src/components/Form';
import { recurseReactClone } from './utils';
import Field from './Field';
-const propTypes = {
- children: PropTypes.node.isRequired,
- onChange: PropTypes.func,
- item: PropTypes.object,
- title: PropTypes.node,
- compact: PropTypes.bool,
-};
-const defaultProps = {
- compact: false,
- title: null,
-};
+interface FieldsetProps {
+ children: React.ReactNode;
+ onChange: Function;
+ item: Record<string, any>;
Review comment:
sigh... well i guess it's better to have an `any` here than no typing at
all. thanks for looking into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
