villebro commented on a change in pull request #17552: URL: https://github.com/apache/superset/pull/17552#discussion_r758105309
########## File path: superset/translations/babel.cfg ########## @@ -14,12 +14,18 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. +# http://babel.pocoo.org/en/latest/messages.html?highlight=mapping%20file#extraction-method-mapping-and-configuration [ignore: superset-frontend/node_modules/**] +[ignore: superset-frontend/packages/superset-ui-demo/**] +[ignore: superset/migrations/**] + [python: superset/**.py] [jinja2: superset/**/templates/**.html] -[javascript: superset-frontend/src/**.js] -[javascript: superset-frontend/src/**.jsx] -[javascript: superset-frontend/src/**.ts] -[javascript: superset-frontend/src/**.tsx] +[javascript: superset-frontend/src/**.js?] +[javascript: superset-frontend/src/**.ts?] +[javascript: superset-frontend/packages/**.js?] +[javascript: superset-frontend/packages/**.ts?] +[javascript: superset-frontend/plugins/**.js?] +[javascript: superset-frontend/plugins/**.ts?] Review comment: I noticed that the `lib` subdirs were also extracted - this seemed to fix it: ```suggestion [javascript: superset-frontend/packages/**/src/**.js?] [javascript: superset-frontend/packages/**/src/**.ts?] [javascript: superset-frontend/plugins/**/src/**.js?] [javascript: superset-frontend/plugins/**/src/**.ts?] ``` ########## File path: .codecov.yml ########## @@ -14,6 +15,17 @@ coverage: # project coverage decrease: target: auto threshold: 0% + core-packages-ts: + target: 95% Review comment: Note to other reviewers - this was set to 95 % due to codecov reporting slightly lower coverage stats than on `superset-ui`. This will be fixed in a follow-up PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
