betodealmeida commented on a change in pull request #16991:
URL: https://github.com/apache/superset/pull/16991#discussion_r758526754
##########
File path: superset/security/manager.py
##########
@@ -14,8 +14,10 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
-# pylint: disable=too-many-lines
+# pylint: disable=too-many-lines, invalid-name
Review comment:
Putting on each statement means you're aware of the rule, and you
consciously decided to break it because practicality beats purity. If you put
it at the top of the model the rule could be broken many times without people
being aware of it, which reduces the code quality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
