villebro commented on a change in pull request #16991:
URL: https://github.com/apache/superset/pull/16991#discussion_r759115014
##########
File path: superset/charts/data/commands/get_data_command.py
##########
@@ -14,6 +14,8 @@
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
+from __future__ import annotations
+
Review comment:
> https://docs.python.org/3/library/__future__.html
> you should add it until all supported versions are at least 3.11
> I use that future for the type hints
Thanks for the heads up, I hadn't seen this PEP, and I agree with the
change. Ugh, not looking forward to seeing `__future__` all around the codebase
again 😖 but I agree it's cleaner than having string-based type references.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
