eschutho commented on a change in pull request #17600:
URL: https://github.com/apache/superset/pull/17600#discussion_r759769713
##########
File path: superset/connectors/base/models.py
##########
@@ -319,8 +320,13 @@ def data_for_slices( # pylint: disable=too-many-locals
if "column" in filter_config
)
+ # for legacy dashboard imports which have the wrong query_context
in them
+ try:
+ query_context = slc.get_query_context()
+ except DatasetNotFoundError:
+ query_context = None
Review comment:
@AAfghahi and I also talked about maybe writing a script/migration as a
follow up that will remove any existing query_context fields from charts if
they contain a dataset id. Either way, it seems that if query context is
failing in any way here, that it would be just as fine not to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
