etr2460 commented on a change in pull request #17603:
URL: https://github.com/apache/superset/pull/17603#discussion_r759881563
##########
File path:
superset-frontend/src/SqlLab/components/EstimateQueryCostButton/index.tsx
##########
@@ -93,7 +91,7 @@ const EstimateQueryCostButton = props => {
triggerNode={
<Button
style={{ height: 32, padding: '4px 15px' }}
- onClick={onClick}
+ onClick={getEstimate()}
Review comment:
yeah, i guess that makes sense :'( maybe add a comment on why the
handler is needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
