AAfghahi commented on a change in pull request #17606:
URL: https://github.com/apache/superset/pull/17606#discussion_r760493671
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -479,39 +480,38 @@ export default class FilterableTable extends
PureComponent<
return (
<StyledFilterableTable>
<ScrollSync>
- {({ onScroll, scrollTop }) => (
- <div
- className="filterable-table-container Table"
- data-test="filterable-table-container"
- ref={this.container}
- >
- <div className="LeftColumn">
- <Grid
- cellRenderer={this.renderGridCellHeader}
- columnCount={orderedColumnKeys.length}
- columnWidth={getColumnWidth}
- height={rowHeight}
- rowCount={1}
- rowHeight={rowHeight}
- scrollTop={scrollTop}
- width={this.totalTableWidth}
- />
- </div>
- <div className="RightColumn">
- <Grid
- cellRenderer={this.renderGridCell}
- columnCount={orderedColumnKeys.length}
- columnWidth={getColumnWidth}
- height={totalTableHeight - rowHeight}
- onScroll={onScroll}
- overscanColumnCount={overscanColumnCount}
- overscanRowCount={overscanRowCount}
- rowCount={this.list.length}
- rowHeight={rowHeight}
- width={this.totalTableWidth}
- />
- </div>
- </div>
+ {({ onScroll, scrollLeft }) => (
+ <>
+ <AutoSizer disableHeight>
+ {({ width }) => (
+ <div>
Review comment:
oh you got rid of the two separate divs (and also got rid of their
classnames). Has that affected any of the css for right and left Column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
