betodealmeida commented on a change in pull request #17573:
URL: https://github.com/apache/superset/pull/17573#discussion_r760696244
##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -321,21 +321,30 @@ export default class FilterableTable extends
PureComponent<
);
}
+ // Parse any floating numbers so they'll sort correctly
+ parseFloatingNums = (value: any) => {
+ const floatValue = parseFloat(value);
+ return Number.isNaN(floatValue) ? value : parseFloat(value);
Review comment:
Nit:
```suggestion
return Number.isNaN(floatValue) ? value : floatValue
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
