kgabryje commented on a change in pull request #17570:
URL: https://github.com/apache/superset/pull/17570#discussion_r763786823
##########
File path: superset-frontend/src/dashboard/actions/dashboardState.js
##########
@@ -194,52 +196,176 @@ export function saveDashboardRequest(data, id, saveType)
{
const serializedFilters = serializeActiveFilterValues(getActiveFilters());
// serialize filter scope for each filter field, grouped by filter id
const serializedFilterScopes = serializeFilterScopes(dashboardFilters);
+ const {
+ certified_by,
+ certification_details,
+ css,
+ dashboard_title,
+ owners,
+ roles,
+ slug,
+ } = data;
+
+ // making sure the data is what the backend expects
+ const cleanedData = {
+ ...data,
+ certified_by: certified_by || '',
+ certification_details:
+ certified_by && certification_details ? certification_details : '',
+ css: css || '',
+ dashboard_title: dashboard_title || t('[ untitled dashboard ]'),
+ owners: owners && owners.length ? owners.map(o => (o.id ? o.id : o)) :
[],
+ roles: !isFeatureEnabled(FeatureFlag.DASHBOARD_RBAC)
+ ? undefined
+ : roles && roles.length
+ ? roles.map(r => (r.id ? r.id : r))
+ : [],
+ slug: slug || null,
+ metadata: {
+ ...data.metadata,
+ color_namespace: data.metadata?.color_namespace || undefined,
+ color_scheme: data.metadata?.color_scheme || '',
+ expanded_slices: data.metadata?.expanded_slices || {},
+ label_colors: data.metadata?.label_colors || {},
+ refresh_frequency: data.metadata?.refresh_frequency || 0,
+ timed_refresh_immune_slices:
+ data.metadata?.timed_refresh_immune_slices || [],
+ },
+ };
+
+ const handleChartConfiguration = () => {
+ const {
+ dashboardInfo: {
+ metadata: { chart_configuration = {} },
+ },
+ } = getState();
+ const chartConfiguration = Object.values(chart_configuration).reduce(
+ (prev, next) => {
+ // If chart removed from dashboard - remove it from metadata
+ if (
+ Object.values(layout).find(
+ layoutItem => layoutItem?.meta?.chartId === next.id,
+ )
+ ) {
+ return { ...prev, [next.id]: next };
+ }
+ return prev;
+ },
+ {},
+ );
+ return chartConfiguration;
+ };
+
+ const onCopySuccess = response => {
+ const lastModifiedTime = response.json.last_modified_time;
+ if (lastModifiedTime) {
+ dispatch(saveDashboardRequestSuccess(lastModifiedTime));
+ }
+ if (isFeatureEnabled(FeatureFlag.DASHBOARD_CROSS_FILTERS)) {
+ const chartConfiguration = handleChartConfiguration();
+ dispatch(setChartConfiguration(chartConfiguration));
+ }
+ dispatch(addSuccessToast(t('This dashboard was saved successfully.')));
+ return response;
+ };
+
+ const onUpdateSuccess = response => {
+ const updatedDashboard = response.json.result;
+ const lastModifiedTime = response.json.last_modified_time;
+ // synching with the backend transformations of the metadata
+ if (updatedDashboard.json_metadata) {
+ const metadata = JSON.parse(updatedDashboard.json_metadata);
+ dispatch(
+ dashboardInfoChanged({
+ metadata: JSON.parse(updatedDashboard.json_metadata),
+ }),
+ );
+ if (metadata.chart_configuration) {
+ dispatch({
+ type: SET_CHART_CONFIG_COMPLETE,
+ chartConfiguration: metadata.chart_configuration,
+ });
+ }
+ }
+ if (lastModifiedTime) {
+ dispatch(saveDashboardRequestSuccess(lastModifiedTime));
+ }
+ // redirect to the new slug or id
+ window.history.pushState(
+ { event: 'dashboard_properties_changed' },
+ '',
+ `/superset/dashboard/${slug || id}/`,
+ );
+
+ dispatch(addSuccessToast(t('This dashboard was saved successfully.')));
+ return response;
+ };
+
+ const onError = async response => {
+ const { error, message } = await getClientErrorObject(response);
+ let errorText = t(
+ 'Sorry, there was an error saving this dashboard: %s',
+ error || t('Unknown'),
Review comment:
Hmm, I think that in the case of undefined error the message would sound
a bit strange: "Sorry, there was an error saving this dashboard: Unknown".
Maybe we should have a separate error message for such case? Like "Unknown
error has occurred" or something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
