villebro commented on a change in pull request #17658:
URL: https://github.com/apache/superset/pull/17658#discussion_r764010165
##########
File path: superset/utils/pandas_postprocessing.py
##########
@@ -820,8 +820,8 @@ def prophet( # pylint: disable=too-many-arguments
freq = PROPHET_TIME_GRAIN_MAP[time_grain]
# check type at runtime due to marhsmallow schema not being able to handle
# union types
- if not periods or periods < 0 or not isinstance(periods, int):
- raise QueryObjectValidationError(_("Periods must be a positive integer
value"))
+ if periods < 0 or not isinstance(periods, int):
Review comment:
Should this be flipped around, just in case the user sends an empty
value?
```suggestion
if not isinstance(periods, int) or periods < 0:
```
The reason we need to do this is because we're currently not validating the
post transformation schemas (I've been unable to get marshmallow to work
properly with union types). Without this change the following error will pop up:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
