ktmud commented on a change in pull request #17587:
URL: https://github.com/apache/superset/pull/17587#discussion_r767055289
##########
File path:
superset-frontend/plugins/plugin-chart-echarts/src/BigNumber/BigNumberTotal/controlPanel.ts
##########
@@ -51,44 +51,45 @@ export default {
},
},
],
+ ],
+ },
+ {
+ label: t('Chart Options'),
+ expanded: true,
+ controlSetRows: [
+ [headerFontSize],
+ [subheaderFontSize],
['y_axis_format'],
[
{
- name: 'header_format_selector',
+ name: 'time_format',
config: {
- type: 'CheckboxControl',
- label: t('Timestamp Format'),
+ type: 'SelectControl',
+ freeForm: true,
+ label: t('Date format'),
renderTrigger: true,
- default: false,
- description: t('Whether to format the timestamp'),
+ choices: D3_TIME_FORMAT_OPTIONS,
+ description: D3_FORMAT_DOCS,
+ default: smartDateFormatter.id,
},
},
],
[
{
- name: 'header_timestamp_format',
+ name: 'force_timestamp_formatting',
Review comment:
Are we renaming existing config props in use? Might need a db migration
script if that's the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
