villebro commented on a change in pull request #17680:
URL: https://github.com/apache/superset/pull/17680#discussion_r767286808
##########
File path: superset-frontend/src/constants.ts
##########
@@ -37,7 +37,7 @@ export const URL_PARAMS = {
},
nativeFilters: {
name: 'native_filters',
- type: 'rison',
+ type: 'rison | string',
},
Review comment:
I agree with @zhaoyongjie that we shold decouple these two to keep the
interface clean and simplify downstream logic (avoid having to check the type
of the object). To keep the name simple, I think we could just call the new one
`filterState`, and that would then contain the key for either native filter
state or filter set state. Ping @amitmiran137 and @simcha90 any opinions here?
##########
File path: superset-frontend/src/dashboard/components/Header/index.jsx
##########
@@ -174,13 +174,15 @@ class Header extends React.PureComponent {
this.startPeriodicRender(refreshFrequency * 1000);
if (this.canAddReports()) {
// this is in case there is an anonymous user.
- this.props.fetchUISpecificReport(
- user.userId,
- 'dashboard_id',
- 'dashboards',
- dashboardInfo.id,
- user.email,
- );
+ if (Object.entries(dashboardInfo).length !== 0) {
Review comment:
nit:
```suggestion
if (Object.entries(dashboardInfo).length) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
