suddjian commented on a change in pull request #17757:
URL: https://github.com/apache/superset/pull/17757#discussion_r769256916
##########
File path: superset/security/manager.py
##########
@@ -1097,6 +1105,12 @@ def get_user_by_username(
def get_anonymous_user(self) -> User: # pylint: disable=no-self-use
return AnonymousUserMixin()
+ def get_user_roles(self) -> List[Role]:
+ if g.user.is_anonymous:
Review comment:
Actually I guess we didn't need to change this method after all. We were
considering a version of `GuestUser` where `is_anonymous == True`, which would
have required changing this. That implementation ended up being too unwieldy in
other places, so `GuestUser.is_anonymous` currently is set to `False`.
But this is still cleaner than having multiple copies of the method
everywhere, so I'm keeping it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
