villebro opened a new pull request #17777: URL: https://github.com/apache/superset/pull/17777
### SUMMARY Currently loading a dashboard with the `DASHBOARD_NATIVE_FILTER_SETS` feature flag enabled triggers a 404 to the `filtersets` dashboard endpoint. This most likely due to a race condition which is caused by the dashboard state to not be available in Redux yet when the filter set request is dispatched. This adds the dashboard id to the `getFilterSets` action to ensure that the caller already has the id available. # AFTER After the change the filter set request results in a 200 with the correct dashboard id:  # BEFORE Before the change, loading a dashboard always triggers a 404 to the filter set endpoint:  ### TESTING INSTRUCTIONS 1. Enable "DASHBOARD_NATIVE_FILTER_SETS" feature flag. 2. Enter a dashboard 3. Observe a 404 to the filter set endpoint ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
