etr2460 commented on pull request #17782:
URL: https://github.com/apache/superset/pull/17782#issuecomment-998133219


   I wanted to make sure that any tests that might hit the presto/hive 
connectors get run here. For example, a test that adds custom configuration 
options to a database (and passes them on to the db engine). some examples of 
the configs:
   
![image](https://user-images.githubusercontent.com/7409244/146808228-a83f7fa0-bcf4-4039-ba3f-88f95fdf4abe.png)
   
   there's also the db impersonation that i believe is unique on a db engine 
level. Ideally we would be testing all these config options on every db engine, 
but for now hive and presto is a start
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to