betodealmeida opened a new pull request #17853:
URL: https://github.com/apache/superset/pull/17853


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Add a new column `force_screenshot` to the reports/alerts model. For alerts 
this is always set to true. For reports this is currently set to false, and 
will be made configurable.
   
   When the flag is true, when generating a screenshot for the alert/report the 
cache will be bypassed.
   
   Depends on https://github.com/apache/superset/pull/17695.
   
   ### MIGRATION
   
   DB migration adds a new column `force_screenshot`, set to true for existing 
alerts, false otherwise.
   
   Results:
   
   Current: 0.34 s
   10+: 0.35 s
   100+: 0.39 s
   1000+: 0.74 s
   10000+: 3.58 s
   100000+: 32.59 s
   1000000+: 453.84 s
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   N/A
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   1. Create a report and a alert.
   2. Run `SELECT force_screenshot FROM report_schedule`, check that it's true 
for the alert and false for the report.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [X] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [X] Migration is atomic, supports rollback & is backwards-compatible
     - [X] Confirm DB migration upgrade and downgrade tested
     - [X] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to