zhaoyongjie commented on a change in pull request #17851:
URL: https://github.com/apache/superset/pull/17851#discussion_r774300957
##########
File path: superset-frontend/plugins/legacy-plugin-chart-map-box/package.json
##########
@@ -30,7 +30,6 @@
"dependencies": {
"@superset-ui/chart-controls": "0.18.25",
"@superset-ui/core": "0.18.25",
- "mapbox-gl": "^0.53.0",
Review comment:
`mapbox-gl` is a dependency from the `react-map-gl`. The root cause for
this issue is that `mapbox-gl` version is incompatible between
`legacy-plugin-chart-map-box` and `legacy-preset-chart-deckgl`.
When we removed `mapbox-gl` in both packages, npm will auto-resolve the
conflict. If the user installs those packages as standalone, `mapbox-gl` will
install by default.
#### `legacy-plugin-chart-map-box` dependencies tree
```
(superset) yongjie.zhao@:superset-frontend$ npm ls --depth 1 | grep -A 30
'map-box'
....
....
├─┬ @superset-ui/[email protected] ->
./plugins/legacy-plugin-chart-map-box
│ ├── @superset-ui/[email protected] deduped ->
./packages/superset-ui-chart-controls
│ ├── @superset-ui/[email protected] deduped -> ./packages/superset-ui-core
│ ├── [email protected] deduped
│ ├─┬ [email protected]
│ │ ├── @babel/[email protected] deduped
│ │ ├── [email protected]
│ │ ├── [email protected]
│ │ ├── [email protected] deduped
│ │ ├── [email protected] deduped
│ │ ├── [email protected] deduped invalid: "^15.5.4" from node_modules/omnibar
│ │ └── [email protected] deduped
│ ├── [email protected] deduped
│ ├─┬ [email protected]
│ │ └── [email protected]
│ └─┬ [email protected]
│ ├── @babel/[email protected] deduped
│ └── [email protected]
....
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
