rusackas commented on a change in pull request #17902:
URL: https://github.com/apache/superset/pull/17902#discussion_r779880344
##########
File path:
superset-frontend/src/explore/components/ExploreAdditionalActionsMenu/ExploreAdditionalActionsMenu.test.jsx
##########
@@ -43,12 +48,15 @@ describe('ExploreAdditionalActionsMenu', () => {
).toBe(true);
});
it('renders a dropdown with 3 items', () => {
- const wrapper = mount(<ExploreAdditionalActionsMenu {...defaultProps} />, {
- wrappingComponent: ThemeProvider,
- wrappingComponentProps: {
- theme: supersetTheme,
+ const wrapper = mount(
+ <ExploreAdditionalActionsMenu store={store} {...defaultProps} />,
+ {
+ wrappingComponent: ThemeProvider,
+ wrappingComponentProps: {
+ theme: supersetTheme,
+ },
Review comment:
Could use `styledMount` here and skip the `supersetTheme` /
`ThemeProvider` bits, if we wanna do a little extra sweeping up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
