zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780002904
##########
File path:
superset-frontend/packages/superset-ui-core/test/chart-composition/legend/WithLegend.test.tsx
##########
@@ -20,8 +20,8 @@
import React from 'react';
import { mount, shallow } from 'enzyme';
import { triggerResizeObserver } from 'resize-observer-polyfill';
-import { promiseTimeout } from '@superset-ui/core/src';
-import { WithLegend } from '@superset-ui/core/src/chart-composition';
+import { promiseTimeout } from '@superset-ui/core';
+import { WithLegend } from '../../../src/chart-composition';
Review comment:
`WithLegend` is a internal var in `@superset-ui/core`, in the other
words `WithLegend` don't export from `@superset-ui/core`
there are lots of internal variables as "private var", we should use
relative import expression to referring to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
