eschutho commented on a change in pull request #17944:
URL: https://github.com/apache/superset/pull/17944#discussion_r780614090
##########
File path: superset-frontend/src/SqlLab/components/QueryTable/index.tsx
##########
@@ -266,35 +290,32 @@ const QueryTable = props => {
)}
placement="top"
>
- <Icons.Edit iconSize="small" />
+ <Icons.Edit iconSize="s" />
</StyledTooltip>
<StyledTooltip
onClick={() => openQueryInNewTab(query)}
tooltip={t('Run query in a new tab')}
placement="top"
>
- <Icons.PlusCircleOutlined
- iconSize="x-small"
- css={verticalAlign}
- />
+ <Icons.PlusCircleOutlined iconSize="s" css={verticalAlign} />
Review comment:
`xs` looks to be a valid size in the typography.sizes. I think it would
be safe to add `xs` to the list here:
superset-frontend/src/components/Icons/IconType.ts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
