etr2460 opened a new pull request #17974: URL: https://github.com/apache/superset/pull/17974
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Currently, when a date is null and it's in a temporal column, it renders as `1970-01-01` instead of `N/A`. This PR fixes it ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Test dataset (generated in SQL Lab):  Table chart before fix:  Table chart after fix:  ### TESTING INSTRUCTIONS CI, new unit test, create a dataset with a temporal column in dev, add at least one row with null, ensure it renders as N/A ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API to: @ktmud @graceguo-supercat @michael-s-molina @rusackas -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
