zhaoyongjie commented on a change in pull request #17947:
URL: https://github.com/apache/superset/pull/17947#discussion_r780326093
##########
File path:
superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from
'@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
IMO, have to keep a simple and straightforward approach to link modules.
We have to consider multiple runtime to alias these module
- Eslint
- Jest
- Webpack
This pattern only keep 1 principle "public variable name import from top
level"
##########
File path:
superset-frontend/packages/superset-ui-core/test/chart/clients/ChartClient.test.ts
##########
@@ -24,17 +24,15 @@ import {
buildQueryContext,
QueryFormData,
configure as configureTranslation,
-} from '@superset-ui/core/src';
-
-import {
ChartClient,
getChartBuildQueryRegistry,
getChartMetadataRegistry,
ChartMetadata,
-} from '@superset-ui/core/src/chart';
-import { SliceIdAndOrFormData } from
'@superset-ui/core/src/chart/clients/ChartClient';
+} from '@superset-ui/core';
+
import { LOGIN_GLOB } from '../fixtures/constants';
import { sankeyFormData } from '../fixtures/formData';
+import { SliceIdAndOrFormData } from '../../../src/chart/clients/ChartClient';
Review comment:
IMO, have to keep a simple and straightforward approach to link modules.
We have to consider multiple runtime to alias these module
- Eslint
- Jest
- Webpack
This pattern only keep 1 principle "public variable name import from top
level"
What do you think about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
