michael-s-molina commented on a change in pull request #17882: URL: https://github.com/apache/superset/pull/17882#discussion_r781232264
########## File path: superset/charts/form_data/commands/delete.py ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from superset.charts.form_data.utils import check_access +from superset.extensions import cache_manager +from superset.key_value.commands.delete import DeleteKeyValueCommand +from superset.key_value.commands.entry import Entry +from superset.key_value.commands.exceptions import KeyValueAccessDeniedError +from superset.key_value.commands.parameters import CommandParameters +from superset.key_value.utils import cache_key + + +class DeleteFormDataCommand(DeleteKeyValueCommand): + def delete(self, cmd_params: CommandParameters) -> bool: + resource_id = cmd_params["resource_id"] + actor = cmd_params["actor"] + key = cmd_params["key"] + check_access(cmd_params) + entry: Entry = cache_manager.chart_form_data_cache.get( + cache_key(resource_id, key) + ) + if entry: + if entry["owner"] != actor.get_user_id(): + raise KeyValueAccessDeniedError() Review comment: We have `test_delete_not_owner` for this but the implementation was wrong. I fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
