michael-s-molina edited a comment on pull request #17976:
URL: https://github.com/apache/superset/pull/17976#issuecomment-1009044225


   > @michael-s-molina @geido Thanks for the explanations! I also agree keeping 
the behavior consistent. btw, I am curious why single-select component would 
keep selected option on top. It is a bit different from other site. Maybe 
scroll to selected option could be better? Since after each selection of value 
will lead to the reorder of the list, if the list is very large there maybe 
some performance issues.
   
   We chose to keep the selected option on top to preserve the same behavior 
between the different types but also because the component is paginated, which 
means that all the results won't be available at a given point. Imagine a 
Select with the names of people and when you open it, only the names that start 
with A are available but the selected value is Sarah. In terms of performance, 
the virtualization and pagination help, we tested with more than 100k values 
and saw no problem. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to