dpgaspar removed a comment on pull request #17984:
URL: https://github.com/apache/superset/pull/17984#issuecomment-1009761673


   > Change LGTM with minor nit. However, since this will break every single 
installation that is currently using the default key, I would prefer to either 
make `CHANGE_ME_SECRET_KEY` equal to the old default `SECRET_KEY`, or add a 
note to `UPDATING.md`. Otherwise I fear we will be swampled by questions on 
both GitHub and Slack from users wondering why their devenvs on master 
(hopefully not prod envs!) have stopped working.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to