hughhhh commented on a change in pull request #18001: URL: https://github.com/apache/superset/pull/18001#discussion_r782537270
########## File path: superset/databases/commands/test_connection.py ########## @@ -78,7 +81,24 @@ def run(self) -> None: ) with closing(engine.raw_connection()) as conn: try: + alive = func_timeout( Review comment: We already have a 408 exception i'd raise this as well https://github.com/apache/superset/blob/master/superset/exceptions.py#L118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org