geido commented on a change in pull request #18080:
URL: https://github.com/apache/superset/pull/18080#discussion_r786930973
##########
File path: superset-frontend/src/explore/components/DatasourcePanel/index.tsx
##########
@@ -123,32 +123,11 @@ const LabelContainer = (props: {
className: string;
}) => {
const labelRef = useRef<HTMLDivElement>(null);
- const [showTooltip, setShowTooltip] = useState(true);
- const isLabelTruncated = () =>
- !!(
- labelRef &&
- labelRef.current &&
- labelRef.current.scrollWidth > labelRef.current.clientWidth
- );
Review comment:
Hey @zhaoyongjie,
It appears that with removing this part we lose the ability to show the
tooltip when the text is truncated. This ability was requested several times in
the past in order to show the full label even when it does not fit the panel
width. I am not sure if there is a consensus on whether it should now be
removed. Please watch the video below that shows that no tooltip is shown when
the text in the panel is truncated. Thank you!
https://user-images.githubusercontent.com/60598000/149977435-2e4e9e15-b02a-44a5-a1d4-dae409893b41.mp4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
