betodealmeida opened a new pull request #18093: URL: https://github.com/apache/superset/pull/18093
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY <!--- Describe the change below, including rationale and design decisions --> There's been increasing interest in managing superset assets (databases, datasets, charts, dashboards) externally. An immediate use case that is possible today is creating a directory with YAML files from the new import/export format: ``` repo/metadata.yaml repo/databases/db.yaml repo/datasets/db/dataset.yaml repo/charts/chart.yaml repo/dashboards/dash.yaml ``` And then periodically syncing the directory to Superset with: ```bash superset import-directory /path/to/repo ``` Even though this works, users are still able to modify these assets in the UI, introducing unintended modifications, as well as frustration for the users when those changes are reverted in the next sync. In addition to the import/export scenario, people have been syncing model (and metric!) definitions [from DBT to Superset](https://github.com/slidoapp/dbt-superset-lineage/) (as well as from Superset to DBT). Users have also shown interest in syncing from [Supergrain](https://www.supergrain.com/) and [Transform](https://transform.co/). This PR introduces 2 new columns to databases, datasets, charts and dashboards: 1. `is_managed_externally`: a boolean defaulting to "false". 2. `external_url`: a nullable string representing an URL pointing to more information about the resource. There are no UI changes in this PR, but I'm planning to modify the CRUD dialogs (and the backend) to prevent editing the resources when `is_managed_externally` is true. In the future we could also add an affordance using `external_url`. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> None. ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> Ran the migration script: ``` Results: Current: 0.28 s 10+: 0.29 s 100+: 0.27 s 1000+: 0.31 s 10000+: 0.27 s 100000+: 0.36 s 1000000+: 0.91 s ``` ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [X] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [X] Migration is atomic, supports rollback & is backwards-compatible - [X] Confirm DB migration upgrade and downgrade tested - [X] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
